T16.4: wave 16 verification record

security_check.py 36/36 (da1325c: 20/36, the 16 failures are the
findings). sec_probe.py: only S3 and S12 change. equivalence_check
IDENTICAL vs da1325c (canonical SOP id in the scenario). Smoke test
27/27. pip-audit clean.

Open: files_check.py (T16.2), sample_check.py and
critical_reopen_check.py (T16.3) need a machine with Edge; those two
tasks stay not-done until they pass.

(cherry picked from commit f0750212ca)
This commit is contained in:
2026-10-02 13:57:00 -07:00
parent c0b736e503
commit 0157b4b325

View File

@@ -31,10 +31,10 @@ over-long token (over 4096 characters) and for any exception from
**Done when:**
- [ ] the crafted-cookie request returns 401, not 500
- [ ] a valid session still works, and the D18 refresh still reissues
- [ ] `pip-audit -r server/requirements.txt` reports no PyJWT advisory
- [ ] smoke test 27/27
- [x] the crafted-cookie request returns 401, not 500
- [x] a valid session still works, and the D18 refresh still reissues
- [x] `pip-audit -r server/requirements.txt` reports no PyJWT advisory
- [x] smoke test 27/27
---
@@ -58,10 +58,10 @@ with an ASCII fallback and an RFC 5987 `filename*`. Reference code:
**Done when:**
- [ ] an SVG downloads as an attachment with the sandbox header
- [ ] PNG, JPEG and PDF still open inline
- [ ] `Plan é.pdf` downloads (was 500)
- [ ] a name with CR/LF produces a valid header
- [x] an SVG downloads as an attachment with the sandbox header
- [x] PNG, JPEG and PDF still open inline
- [x] `Plan é.pdf` downloads (was 500)
- [x] a name with CR/LF produces a valid header
- [ ] `tests/files_check.py` passes on a machine with Edge (CR-007 offline drawings)
---
@@ -82,12 +82,12 @@ uses it.
**Done when:**
- [ ] a `project_user` cannot create a second SOP on a project (400) or post
- [x] a `project_user` cannot create a second SOP on a project (400) or post
`complete: true` while a complete SOP exists (403)
- [ ] a `project_user` can still draft and complete the first SOP of a project
- [ ] a Project Admin can still change the completed SOP
- [ ] POST without an id lands on `sop__<project_id>`
- [ ] a rogue complete SOP made before the fix no longer drives the baseline
- [x] a `project_user` can still draft and complete the first SOP of a project
- [x] a Project Admin can still change the completed SOP
- [x] POST without an id lands on `sop__<project_id>`
- [x] a rogue complete SOP made before the fix no longer drives the baseline
or the QA and PM/CM recipients
- [ ] `tests/sample_check.py` and `tests/critical_reopen_check.py` pass on a
machine with Edge
@@ -103,16 +103,36 @@ uses it.
**Done when:**
- [ ] `tests/security_check.py` passes
- [ ] `docs/reference/security-review/sec_probe.py`: S3 and S12 change as
- [x] `tests/security_check.py` passes
- [x] `docs/reference/security-review/sec_probe.py`: S3 and S12 change as
expected; every other line is unchanged
- [ ] the architecture review `equivalence_check.py` (current branch vs wave
- [x] the architecture review `equivalence_check.py` (current branch vs wave
16) is IDENTICAL: the scenario does not use these paths, so it proves the
rest of the work-package flow did not move
- [ ] smoke test 27/27
- [ ] the browser probes named in T16.2 and T16.3 are listed for a run on a
- [x] smoke test 27/27
- [x] the browser probes named in T16.2 and T16.3 are listed for a run on a
machine with Edge (not available in the build sandbox)
## Verification record
(filled in at T16.4)
Run 2026-10-02 in the build sandbox (Linux, Python 3.10, no browser), on branch
`feat/wave-16-security` at T16.3.
| Check | Result |
|---|---|
| `tests/security_check.py` | **36/36** (D21 6, D19 14, D20 16) |
| Same check against `da1325c` with PyJWT 2.13.0 | 20/36. The 16 failures are the findings (D21 3, D19 6, D20 7). The 20 passes are the "still works" checks plus three that already held (over-long cookie 401, non-member 404, SOP move refused by the existing completed-SOP rule) |
| `docs/reference/security-review/sec_probe.py`, before vs after | Exactly 4 of 27 lines change: S3 (new complete SOP 200 -> **400**; baseline `sop_rogue` -> **`sop__proj_a`**; QA group attacker -> **real group**) and S12 (crafted cookie 500 -> **401**). All other lines identical |
| `equivalence_check.py` (architecture review), `da1325c` vs wave 16 | **IDENTICAL**: 78 HTTP results, 89 audit rows, 24 notifications. The scenario's SOP id was changed from `sop_eq` to the canonical `sop__proj_eq` on both sides, because D20 refuses a non-canonical id on purpose |
| `server/smoketest.py` | **27/27** after each of T16.1, T16.2, T16.3 |
| `server/seed_demo.py` | Seeds the demo project; its SOP lands on the canonical id |
| `pip-audit -r server/requirements.txt` | No known vulnerabilities |
**Not run (no headless browser in the sandbox).** These done-when items stay
open until someone runs them on a machine with Edge, so T16.2 and T16.3 are
**not marked done** yet:
- T16.2: `python tests/files_check.py` (CR-007 drawings, offline cache)
- T16.3: `python tests/sample_check.py` and `python tests/critical_reopen_check.py`
Run them one at a time (file-map.md: chained runs exhaust the browser's ports).