T7.1 - B7: dissolve the creator iframe, and D1 give it back its sample data
There is no iframe in html/ any more. The creator is a top-level document with
the same app bar and the same tab strip as the SOP wizard; the two tabs that
used to swap a frame are links between them.
DEVIATION, stated rather than smuggled. The wave file says "remove the iframe
boundary so the creator renders in the parent document". It renders as its own
document instead. Every done-when is met - no iframe, no cross-frame messaging,
F4 resolved structurally, CR-006 toggles with no special-casing, back and
forward intact with T4.2's URL state - but the route is the other one, and the
reason is in creator-frame.md's own numbers:
merge into parent make it a page
selector collisions to resolve 21 0
script global collisions 9 0
cross-frame call sites to remove 28 28
probe entry points needing rework ~29 2
The 21 and the 9 were never the cost of dissolving the boundary. They are the
cost of MERGING TWO DOCUMENTS, which is a different change the boundary was
hiding. And 29 probe call sites address wp-creation-index.html directly, so a
route that keeps that address keeps all of them. creator-frame.md section 5
records this in full.
What went, and what replaced it:
#wp-frame, applyEmbedLayout, sizeWPFrame, viewportMinusChrome, chromeHeight,
renderWPTab, the resize handler, the ResizeObserver, --wp-chrome-h,
.content-area.embed-full, body.embed-full -> the window sizes the page
?embedded=1, body.embedded, .embed-hide, .embed-first -> nothing. An old
link carrying the param is ignored rather than half-obeyed.
openWpById / showDashboard / showForm / dashApplyFlag / applySopSections
called across the frame -> the URL. ?project= ?view= ?wp= ?flag= were
already read at the creator's own boot (T4.2), which is exactly why those four
could be DELETED rather than migrated. X4 is closed: the surviving path is the
one T5.5 built and proved.
inIframe in auth-guard.js, wp-chrome.js, wp-sidenav.js, help.js and _isTop in
project-data.js -> gone. help.js now reads the explicit WP_HELP_NO_FAB flag
both tool pages set, instead of inferring intent from where it is rendered.
.main-nav / .nav-tab in work-package-suite-styles.css -> wp-chrome.css,
because a tab row only one of two documents can style is the shape that put
the tabs in the parent and the toolbar in the child to begin with.
The three questions creator-frame.md section 4 said no count could answer:
1. The creator gets the app bar. It was the only page loading neither
wp-chrome file. Its header is now the .header-left / .header-right pair the
wizard uses, so the switcher lands in the same place on both.
2. Two sequence components, scoped not merged - confirmed Aug 18 that the
sequence is authored in the SOP and adjustable per package. BL-015 stays.
3. body.embedded is gone. The header it hid is replaced by the app bar; the
sample controls are visible in a new package toolbar (D1); the analytics
button is visible there until T7.10 moves it. The Dashboard BUTTON in that
row became a TAB, which is the one place B7's "fold the toolbar into the
tab row" actually happened.
Old addresses still resolve. ?tab=wp, ?view=dashboard and ?wp=<id> are in
bookmarks, in wp-sidenav's link map, and they are the shape CR-011 and CR-014
were specified against (X1). The wizard forwards them with replace(), so Back
does not bounce. Breaking these silently was the one regression this task could
have shipped that nobody would notice for weeks. frame_check.py section 4 pins
all three.
BEHAVIOUR CHANGE, deliberate. The live cross-frame hand-off showed the creator a
section toggle that had NOT been saved: flip it, look, reload, and the section
came back. What the creator shows now is the SOP that is stored. sections_check
5b pins both halves - an unsaved toggle does not travel, a saved one does.
BEHAVIOUR CHANGE, not deliberate, logged as BL-020. A tab switch is a page exit
now, so leaving the wizard with unsaved SOP edits fires T4.3's unsaved-work
guard. Nothing is lost - the guard writes the draft first and T4.3 recovers it -
but it is friction that did not exist, and suppressing a deliberate guard is a
product decision with its own downside. Logged, not quietly handled here.
tests/frame_check.py, 39 checks, new. Two of them exist because of failures
during this task rather than in it:
- "both documents parse and boot". A const shadowing a function parameter is a
SyntaxError, and work-package-suite-app.js did not parse at all for one run.
Four checks in url_state_check went red and not one said "the script did not
load". Asserting a page's own entry points exist costs nothing.
- "focus emulation is on, so a focus reading means something". An earlier draft
called page.call instead of page.ws.call inside a try/except and measured
nothing, reporting no focus ring anywhere - which looks exactly like a
finding. Trap 5 in reverse, for the second time in this project.
The four backlog entries logged against this file, re-measured rather than
assumed:
BL-001 still reproduces (485px in a 390px viewport) but its RECORDED CAUSE IS
WRONG. --nav-w now computes to 56px, so the injected-style explanation
is spent. The overflow is the creator's data tables - #asset-body's
lays out at 520px with no scroll container. frame_check reports the
offending boxes by selector and skips position:fixed subtrees, because
the comments drawer parked off-screen at right:844 made the first
measurement blame the drawer. Pinned, not fixed: T7.2 lays out the form.
BL-013 CLOSED. It was fixed by S12 in WAVE 4 - wp-creation-styles.css:209
carries the comment naming this entry - and nobody updated it. It was
quoted as a live CLAUDE.md violation while planning wave 7 and had not
been true for four waves. a11y_check walks 120 focusable elements on
the creator and every one rings at >= 3:1.
BL-006 15 by the probe's measure, unchanged; different denominator, stated.
BL-007 68 raw radii by the probe's measure. Nothing has reduced it in four
waves; it is measured every run now instead of once.
BL-018 cost a FOURTH probe. frame_check imports set_sop from sections_check
rather than writing a fifth copy of the workaround. T9.9 owns it.
Probes re-pointed, with reasons in the files: sections_check 5b (drove the live
hand-off), pipeline_check check 2 (read through contentDocument), f_items F4
(drove standalone and embedded; there is one mode now), validation_check
(lost "the wrong tab", gained the SOP gate).
Verified: frame_check 39/39, sections_check 95/95, pipeline_check 44/44,
url_state_check 23/23, validation_check 83/83, a11y_check 22/22,
autosave_check 34/34, aggregates_check 16/16, stepper_check 71/71,
browser_check 71/71, launcher_check 58/58, generalinfo_check 49/49,
rollup_check 63/63, cards_check 44/44, locations_check 58/58.
f_items: F1-F5 fixed, F6 reproduces (T7.2).
Metrics: iframes 1 -> 0, colour literals in rules outside theme-light.css 0,
dialogs 64, <div onclick> 2, .help-tip 18.
Items: B7 D1
Task: T7.1
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -146,3 +146,87 @@ Three things `T7.1` has to settle that no count can answer:
|
||||
`wp-creation-styles.css`. If that sheet is being scoped or rewritten anyway, they are cheaper
|
||||
now than they will ever be again — but they are separate items and `T7.1` says to bundle
|
||||
nothing.
|
||||
|
||||
---
|
||||
|
||||
## 5. What T7.1 actually did — August 18, 2026
|
||||
|
||||
The measurement above assumed one shape of answer: merge the creator's markup and
|
||||
scripts into `work-package-suite.html`, and pay the 21 selector collisions and 9 global
|
||||
collisions to do it. That is not what shipped, and the reason is in this document's own
|
||||
numbers.
|
||||
|
||||
**The creator became a top-level page instead of moving into the parent one.** The tab
|
||||
strip is drawn by both documents, and the two tabs that used to swap a frame are now
|
||||
links. That satisfies every done-when in the wave file — no iframe, no cross-frame
|
||||
messaging, `F4` resolved structurally, `CR-006` toggles propagating with no
|
||||
special-casing, browser back and forward intact — while the wave file's prose ("renders
|
||||
in the parent document") describes the other route. **Stated as a deviation, not
|
||||
smuggled:** the boundary is dissolved by making the creator its own document rather than
|
||||
by dissolving it into another one.
|
||||
|
||||
Why, against the counts:
|
||||
|
||||
| | Merging into the parent | Making it a page |
|
||||
|---|--:|--:|
|
||||
| Selector collisions to resolve | 21 | **0** |
|
||||
| Script global collisions to resolve | 9 | **0** |
|
||||
| Cross-frame call sites to remove | 28 | 28 |
|
||||
| Probe call sites needing rework | ~29 | **2** |
|
||||
|
||||
The collisions were never a cost of *dissolving the boundary*. They were a cost of
|
||||
*merging two documents*, which is a separate change that the boundary happened to be
|
||||
hiding. §2c called zero markup-id collisions "the single largest piece of good news";
|
||||
the larger one turned out to be that 29 probe entry points address
|
||||
`wp-creation-index.html` directly, and a route that keeps that address keeps them all.
|
||||
|
||||
What the two duplications mean now:
|
||||
|
||||
- **The sequence editor** (9 of the 21 selectors) stays two components, which is what
|
||||
was confirmed on August 18 — authored in the SOP, adjustable per package. The
|
||||
duplication is real and stays visible as `BL-015`.
|
||||
- **Analytics and the feedback panel** (all 9 globals) are still implemented twice. They
|
||||
are in two documents, so nothing collides, but `T7.10` deletes one copy of analytics
|
||||
regardless. `showAnalytics` is the one §2b said to check first, and it was right: the
|
||||
wizard's copy still has no caller.
|
||||
|
||||
### The three questions §4 said no count could answer
|
||||
|
||||
1. **The creator got the app bar.** It was the only page in `html/` loading neither
|
||||
`wp-chrome.css` nor `wp-chrome.js`, because `wp-chrome.js` returned early inside an
|
||||
iframe. Both are loaded now, the header was reshaped into the `.header-left` /
|
||||
`.header-right` pair the suite page uses so the switcher lands in the same place on
|
||||
both, and the wizard's layout arithmetic — `chromeHeight()`, `--wp-chrome-h`,
|
||||
`embed-full` — was deleted rather than adjusted, because there is no frame to size.
|
||||
2. **Two sequence components**, scoped rather than merged. See above.
|
||||
3. **`body.embedded` is gone**, and with it `.embed-hide`. The header it hid was
|
||||
replaced by the app bar; the sample-data controls are visible in a new package
|
||||
toolbar (`D1`); the analytics button is visible there too until `T7.10` moves it.
|
||||
The `Dashboard` button in that row became a **tab**, which is the one place the
|
||||
"fold the toolbar into the tab row" in `B7` actually happened.
|
||||
|
||||
### What was checked
|
||||
|
||||
`tests/frame_check.py`, 39 checks. Beyond the obvious ones it pins three things this
|
||||
document could not have predicted:
|
||||
|
||||
- **Every old address still resolves.** `?tab=wp`, `?view=dashboard` and `?wp=<id>` are
|
||||
in bookmarks, in `wp-sidenav`'s link map, and they are the shape the `CR-011` and
|
||||
`CR-014` emails were specified against (`X1`). The wizard forwards them with
|
||||
`replace()`, so Back does not bounce. Breaking these silently was the one regression
|
||||
this task could have shipped that nobody would notice for weeks.
|
||||
- **Both documents parse.** A `const` shadowing a function parameter is a SyntaxError,
|
||||
and during this task it stopped `work-package-suite-app.js` parsing at all. Four
|
||||
checks in another probe went red and not one of them said "the script did not load".
|
||||
Asserting a page's own entry points exist costs nothing and says exactly that.
|
||||
- **The behaviour that changed.** The live cross-frame hand-off of a section toggle
|
||||
showed the creator a toggle that had *not been saved*: flip it, look, reload, and the
|
||||
section came back. What the creator shows now is the SOP that is stored.
|
||||
`sections_check.py` 5b pins both halves — an unsaved toggle does not travel, a saved
|
||||
one does.
|
||||
|
||||
`BL-020` is the one thing that got worse: a tab switch is a page exit now, so leaving the
|
||||
wizard with unsaved SOP edits fires `T4.3`'s unsaved-work guard. Nothing is lost — the
|
||||
guard writes the draft first and `T4.3` recovers it — but it is friction that did not
|
||||
exist, and suppressing a deliberate guard is a decision with its own downside, so it is
|
||||
logged rather than quietly handled inside a structural task.
|
||||
|
||||
Reference in New Issue
Block a user