n.siegfried/Project-SDE-WP-Suite
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

T5.4 - CR-005: a per-project location taxonomy, stored as codes

Browse Source 
CLAUDE.md lists CR-005 among the change requests that get "silently half-built if
you treat them as frontend-only". This is the server half and the wizard half
together: a new table, four routes, an Alembic revision, and step 11.

CODES, NOT DISPLAY STRINGS, because CR-018 rolls cost up by these values and a
rollup keyed on a label breaks the day somebody fixes a typo in it. Two columns
carry that: `code` is a node's own slug, derived once at import and never
recomputed; `path` is the full slug path, unique per project, and is what a work
package will store. Renaming a value changes `name` alone - the probe renames a
floor and demands its path comes back byte-identical, with its children's paths
intact.

DEACTIVATE, NEVER DELETE. There is no DELETE route, and the probe checks for its
absence (405) rather than trusting that nobody added one. Deactivating hides a
value from new work packages and cascades DOWN, because a floor nobody can pick
must not keep offering its sectors. Reactivating walks UP only - a sector may
have been switched off for its own reasons, and silently resurrecting it would
undo a decision nobody made twice. That asymmetry is deliberate and is pinned by
a named check so it does not get "fixed" into a surprise.

Import reports rather than merges. Rejected rows come back with the SOURCE line
number and a reason; duplicates are listed as duplicates, separated into "already
in this project" and "already on line N of this import". Reusing a parent is not
a duplicate - B1/L2/1P and B1/L2/2P share a building and a floor by design, and
only the full path repeating counts. Re-importing a deactivated value brings the
same row back rather than creating a second one; the probe checks the id.

One parser, on the server. A CSV is read in the browser and posted as text
exactly as a paste is, so "what does a blank column mean" has one answer.
Comma, semicolon and tab all work - a paste out of a spreadsheet is tab
separated and a saved CSV is not, and which one somebody has is a question the
machine can answer.

No guessed floor names. IMPLEMENTATION.md section 8 says the B100 list has not
been supplied. The seeded sample has "Sample" inside every string, and the probe
greps html/ and server/ for a location-shaped assignment containing any of the
review's real names.

  server/models.py                    LocationNode
  server/alembic/versions/e2a4c7d91b30_location_taxonomy.py
  server/app.py                       GET/POST/PATCH + import, parser, slug
  html/work-package-suite.html        step 11, an 11th rail button
  html/work-package-suite-app.js      the step's logic; LAST_STEP replaces 10
  html/work-package-suite-styles.css  the list, the report
  html/theme-light.css                .field-error, now declared once
  tests/locations_check.py            new - 58 checks
  tests/stepper_check.py              STEP_COUNT 10 -> 11

Done when
  [x] CSV upload and paste both work and report rejected rows with reasons
  [x] duplicates are detected and reported rather than silently merged
  [x] values are editable after import - rename, add, deactivate
  [x] deactivating hides it from new work packages; an existing package
      referencing it still resolves, because the row is retained
  [x] values are stored as codes suitable for grouping
  [x] no guessed real-world floor names exist anywhere in the code

Two decisions worth disagreeing with

  Step 11, appended, not step 2, inserted. Locations belong beside Project by
  subject. Renumbering 2-10 would touch every sop-step-N id, every
  collectStepData case, every gate key and the analytics history - a large
  silent-mismatch surface for an ordering change. The count now lives in one
  place (LAST_STEP), so reordering later is cheap.

  Any project member may edit the list, not only a Project Admin. It matches how
  the SOP baseline itself is authored: the Project Admin gate is on CHANGING a
  completed SOP, not on writing one. If the location list should be tighter than
  the SOP it belongs to, that is a product call.

Verified one at a time
  locations_check  58/58  new
  stepper_check    70/70  (11 steps)
  browser_check    71/71
  a11y             22/22  sop now rings 38 focusable elements
  url_state        23/23
  autosave         34/34
  aggregates       16/16
  pipeline         43/43
  launcher         58/58
  f_items          F1-F5 FIXED, F6 REPRODUCES (T7.2)
  alembic          upgrade / downgrade / upgrade all clean on a throwaway SQLite
                   file, and the migrated schema matches Base.metadata.create_all
                   column for column - dev auto-creates and production migrates,
                   so a divergence between the two is invisible until it ships

.field-error was declared in two page sheets by the end of T5.2 and would have
been three by T5.8, so it moved to theme-light.css. No colour literal added
anywhere: still 0 across all page sheets and inline blocks.

Question for the PR, per CLAUDE.md: the levels are fixed at building / floor /
sector. Micron's floors behave like buildings, which this handles by letting a
project use whichever levels it needs - but a job that wants a fourth level, or
different names for the three, cannot say so. Whether that is worth a
per-project level vocabulary is a product question; the schema would take it
without a migration.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Nick Siegfried
2026-08-16 11:06:27 -05:00
parent 6088ef17e8
commit 2081c1ad3c
11 changed files with 1397 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
html/work-package-suite-styles.css
View File

@@ -625,6 +625,83 @@ body.embed-full { overflow: hidden; }
.nav-btn:disabled { opacity: 0.5; cursor: not-allowed; }
/* ══ LOCATION LIST — CR-005 (step 11) ═════════════════════════════════════════
Building / floor / sector, configured per project. The code beside each name
is the thing CR-018 rolls cost up by, and it is shown rather than hidden so it
is obvious that renaming a value does not move it. */
.loc-actions { display: flex; gap: var(--wp-s2); flex-wrap: wrap; margin-top: var(--wp-s3); }
.loc-report { margin-top: var(--wp-s3); font-size: 13px; }
.loc-report:empty { display: none; }
.loc-report-line { margin: 0 0 var(--wp-s2); }
.loc-report-group { margin-top: var(--wp-s3); }
.loc-report-title { font-size: 12px; font-weight: 600; color: var(--text-light); }
.loc-report-list { margin: var(--wp-s1) 0 0; padding-left: var(--wp-s5); }
.loc-report-list li { margin-bottom: var(--wp-s1); color: var(--text-light); }
.loc-line { font-weight: 600; color: var(--text); }
/* A report that lost rows says so in its own right, not only by wording. */
.loc-report.is-problem { border-left: 3px solid var(--warning); padding-left: var(--wp-s3);
background: var(--warning-bg); padding-top: var(--wp-s2); padding-bottom: var(--wp-s2); }
#loc-list { display: flex; flex-direction: column; margin-top: var(--wp-s3); }
.loc-row {
display: flex;
align-items: center;
gap: var(--wp-s3);
padding: var(--wp-s2);
border-bottom: 1px solid var(--border);
flex-wrap: wrap;
}
/* Indentation is the hierarchy, and it is not the only cue — .loc-level names
the level in words beside it (C1: never colour or position alone). */
.loc-depth-1 { padding-left: var(--wp-s5); }
.loc-depth-2 { padding-left: var(--wp-s6); }
.loc-level {
flex: none; min-width: 68px;
font-size: 11px; font-weight: 600; letter-spacing: .04em;
color: var(--text-light);
}
.loc-name {
flex: 1 1 180px; min-width: 0;
padding: var(--wp-s1) var(--wp-s2);
border: 1px solid var(--border-strong);
border-radius: 0;
background: var(--cds-field);
color: var(--text);
font: inherit;
font-size: 13px;
}
.loc-code {
flex: none;
font-family: var(--wp-font-mono);
font-size: 12px;
color: var(--text-light);
}
.loc-toggle { display: flex; align-items: center; gap: var(--wp-s1); font-size: 12px; color: var(--text-light); }
/* A deactivated value is still listed — that is how it is brought back — but it
reads as out of use, by strikethrough as well as by the unticked box. */
.loc-row.is-off .loc-name { text-decoration: line-through; color: var(--text-light); }
.loc-row.is-off .loc-code { text-decoration: line-through; }
.loc-addrow {
display: flex; align-items: center; gap: var(--wp-s2); flex-wrap: wrap;
margin-top: var(--wp-s4);
}
.loc-addlabel { font-size: 12px; font-weight: 600; color: var(--text-light); }
.loc-addrow select, .loc-addrow input {
padding: var(--wp-s2);
border: 1px solid var(--border-strong);
border-radius: 0;
background: var(--cds-field);
color: var(--text);
font: inherit;
font-size: 13px;
}
.loc-addrow input { flex: 1 1 200px; min-width: 0; }
/* .field-error is declared once, in theme-light.css — the launcher's create form
and T5.8's step validation use the same component. */
/* NAVIGATION */
.step-navigation {
grid-column: 2;