Archive projects, auto-add default members, rebuild the admin console
Three things asked for together, plus the migration they share (a7c31f9e5b02 —
additive, with database defaults for existing rows, so unlike the users.role
rewrite it is safe under a code-only rollback).
ARCHIVE A PROJECT. A finished job leaves every picker, switcher and search, and
freezes read-only, without losing anything. Hiding is free: GET /api/projects
defaults to archived=exclude, so the home picker and the app-bar switcher drop it
without either of them changing. Freezing is require_project_writable(), which
every write that lands on a project now goes through — SOP and WP upserts (both
ends, so a package can be moved neither into nor out of an archived job), deletes,
issue, status, WP archive, and comments on its WPs/SOPs. It answers 409, not 403:
nobody lacks a permission, the project's state is the objection, and the browser
outbox in project-data.js retires 4xx ops instead of retrying them against a job
that will never accept them. Unarchive and delete stay allowed on purpose —
unarchive is the one write an archived project must take, and archive-then-delete
is a normal sequence.
DEFAULT MEMBERS ON NEW PROJECTS. users.auto_add_projects / auto_add_role flag the
people who belong on every job, so an admin says it once instead of remembering it
at each project creation. It runs on the is_new branch of upsert_project, which is
the single road into project creation, so the home page, the sample project and the
demo seeder are all covered and an update never re-runs it. Note the interaction
with the existing creator-grant: that row commits first and add_default_members
never overwrites an existing membership, so the creator grant now carries the
creator's own auto_add_role — otherwise someone flagged "Project Admin on every
job" would land as a plain member on the one job they started themselves.
ADMIN CONSOLE. The user table had outgrown .wrap{max-width:860px}: nine columns in
an 860px card meant every cell wrapped, so one user occupied a ~100px band, the
action buttons stacked, and the table spilled outside its own white card. Now
1240px, with wide tables scrolling inside .tscroll so the page itself never scrolls
sideways, and one spacing/control scale across all twelve cards. Truncation hangs
off a span inside the cell rather than max-width on the td, which table-layout:auto
treats as advisory — the usual reason cell ellipsis works in the stylesheet and not
on the page.
Found in review and fixed here rather than later:
- Stored XSS in the new Projects card, reachable by any signed-in user, landing in
an admin's session. The uesc(v).replace(/'/g,"\'") idiom this file already used
in eight places escapes in the wrong order — uesc leaves backslashes alone, so a
stored name containing \' closes the JS string literal and the rest executes.
jsq() does backslash, then quote, then HTML, and all thirteen handler bindings go
through it. The same bug, unescaped entirely, was in the SOP builder's custom
constraint names (escHandlerArg there). Three of seven test payloads escaped the
literal under the old idiom — one of them a plain name ending in a backslash, so
it was breaking buttons for innocent input too.
- _save_comment resolved wp_id and sop_id with if/elif but stored both, so a
payload naming a WP you may touch and a SOP you may not was authorised on the WP
alone and still wrote into the other project's thread. Both are checked now.
- Promoting an account to admin left its default-member flag set but invisible,
ready to take effect again on demotion — cleared, as set_user_auto_add already
does for the role.
smoketest.py and the console's own smoke test both assert the archive round trip:
out of the default list, present with archived=all, writes refused with 409, and
all of it undone by unarchiving.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -209,11 +209,11 @@ users on the same project see the same server-stored SOP and Work Packages.
|
||||
|
||||
| Table | Holds | Key columns |
|
||||
|-------|-------|-------------|
|
||||
| `projects` | top-level construction projects | `name`, `number`, `client`, `division`, `site`, `sample`, `data` |
|
||||
| `projects` | top-level construction projects | `name`, `number`, `client`, `division`, `site`, `sample`, `archived_at`, `data` |
|
||||
| `sops` | project SOP baselines | `project_id` → projects, `name`, `number`, `complete`, `data` (full SOP JSON) |
|
||||
| `work_packages` | individual IWPs | `project_id` → projects, `sop_id` → sops, `parent_id` (split instances), `number`, `subject`, `type`, `status`, `assignee_id` (owner), `issued_at`, `archived_at`, `data` (full WP JSON) |
|
||||
| `comments` | feedback from any page | `source`, `sop_id`, `wp_id`, `step`, `author`, `text`, `extra` |
|
||||
| `users` | login accounts | `username`, `password_hash` (bcrypt), `role`, `full_name`, `email`, `is_active`, login-lockout + `token_version` fields |
|
||||
| `users` | login accounts | `username`, `password_hash` (bcrypt), `role`, `full_name`, `email`, `is_active`, `auto_add_projects` + `auto_add_role` (default membership on new projects), login-lockout + `token_version` fields |
|
||||
| `project_members` | per-project access control | `user_id` → users, `project_id` → projects |
|
||||
| `audit_log` | append-only activity trail | `actor`, `action`, `entity_type`, `entity_id`, `project_id`, `summary`, `detail` |
|
||||
| `notifications` | in-app record + email outbox | `user_id`, `kind`, `wp_id`, `subject`, `status` (pending / sent / failed / skipped) |
|
||||
@@ -224,18 +224,23 @@ column; frequently-listed fields are promoted to real columns for filtering.
|
||||
|
||||
### Endpoints (summary)
|
||||
|
||||
Projects `GET/POST /api/projects`, `GET/DELETE /api/projects/{id}` ·
|
||||
Projects `GET/POST /api/projects`, `GET/DELETE /api/projects/{id}`,
|
||||
`POST /api/projects/{id}/archive` ·
|
||||
SOPs `GET/POST /api/sops`, `GET /api/sops/latest`, `GET/DELETE /api/sops/{id}` ·
|
||||
Work Packages `GET/POST /api/wps`, `GET/DELETE /api/wps/{id}`,
|
||||
`POST /api/wps/{id}/issue`, `POST /api/wps/{id}/status`, `POST /api/wps/{id}/archive`,
|
||||
`GET /api/wps/metrics` ·
|
||||
Comments `POST /api/comments` (and `/api/feedback`), `GET /api/comments` ·
|
||||
Auth `POST /api/auth/login` / `logout`, `GET /api/auth/me`, admin user management
|
||||
under `/api/auth/users` · Admin-only `GET/PUT /api/settings`,
|
||||
under `/api/auth/users` (including `POST /api/auth/users/{id}/auto-add`) ·
|
||||
Admin-only `GET/PUT /api/settings`,
|
||||
`POST /api/settings/test-email`, `GET /api/notifications`,
|
||||
`GET /api/projects/{id}/members`.
|
||||
List/latest/metrics accept a `project_id` (and `sop_id`) filter. Full reference
|
||||
and request shapes: `/api/docs` and [`server/README.md`](server/README.md).
|
||||
List/latest/metrics accept a `project_id` (and `sop_id`) filter. `GET /api/projects`
|
||||
and `GET /api/wps` both take `archived=exclude|only|all` and **default to
|
||||
`exclude`** — anything that needs to see archived rows (the admin console, the demo
|
||||
cleanup) must ask for them. Full reference and request shapes: `/api/docs` and
|
||||
[`server/README.md`](server/README.md).
|
||||
|
||||
---
|
||||
|
||||
@@ -416,8 +421,9 @@ not get a second bar.
|
||||
- Switching project reloads the current page with `?project=<id>`; every page
|
||||
already resolves its project from that parameter.
|
||||
- Search calls `GET /api/search?q=`, which is **scoped to the caller's projects**
|
||||
(`scope_to_access`) and hides archived work packages. LIKE wildcards in the query
|
||||
are escaped, so searching `100%` matches a literal `100%`. Two-character minimum.
|
||||
(`scope_to_access`) and hides archived work packages, archived projects, and
|
||||
anything belonging to an archived project. LIKE wildcards in the query are escaped,
|
||||
so searching `100%` matches a literal `100%`. Two-character minimum.
|
||||
- Ctrl/Cmd-K focuses the field from anywhere.
|
||||
|
||||
## Schema migrations (Alembic)
|
||||
@@ -470,6 +476,53 @@ the project's members plus app admins, each with their effective role on that
|
||||
project. A project with nobody assigned shows only the admins, which is why
|
||||
assigning people is the first step on a new job.
|
||||
|
||||
### Default members on new projects
|
||||
|
||||
Memberships are also created automatically. **Admin console → Default members on
|
||||
new projects** flags accounts (`users.auto_add_projects`) that belong on every job —
|
||||
the PM who runs them all, the QC lead — with the role they should hold there
|
||||
(`users.auto_add_role`, sharing `project_members.role`'s value space, `''` =
|
||||
inherit the account's own).
|
||||
|
||||
- It applies **only to projects created after the flag is set**. Nothing is
|
||||
back-filled onto existing jobs; use **Project access** for those.
|
||||
- App admins are skipped (they already reach every project) and the flag is cleared
|
||||
if an account is promoted to admin. Inactive accounts are skipped.
|
||||
- Runs in `add_default_members()` on the `is_new` branch of `upsert_project`, so it
|
||||
covers every route into project creation — the home page, the sample project, the
|
||||
demo seeder. An update never re-runs it.
|
||||
- If the creator is themselves a flagged member, the membership created for them as
|
||||
creator carries their `auto_add_role`, so they aren't silently downgraded on the
|
||||
one job they started.
|
||||
- Audit-logged once per project as `project_access_granted` with
|
||||
`detail.reason = "auto_add_projects"`.
|
||||
|
||||
## Archiving a project
|
||||
|
||||
A finished job is archived rather than deleted: `projects.archived_at`, set from
|
||||
**Admin console → Projects** (or `POST /api/projects/{id}/archive`, which needs
|
||||
Project Admin **on that project**, same bar as deleting it).
|
||||
|
||||
An archived project is **hidden and frozen**:
|
||||
|
||||
- It leaves the home picker, the app-bar switcher and global search, because
|
||||
`GET /api/projects` defaults to `archived=exclude`.
|
||||
- It is still readable by id, so a deep link renders it — with a read-only banner
|
||||
from `wp-chrome.js` — and the admin console still lists it under
|
||||
`?archived=all`.
|
||||
- Every write that lands on it is refused with **409** by
|
||||
`require_project_writable()`: saving a project, SOP or work package, deleting
|
||||
either, issuing, status changes, WP archiving, and comments on its WPs/SOPs.
|
||||
Moving a work package *into* or *out of* an archived project is refused too.
|
||||
409 rather than 403 is deliberate — nobody lacks a permission, the project's state
|
||||
is the objection, and the browser outbox (`html/project-data.js`) retires 4xx ops
|
||||
instead of retrying them forever.
|
||||
- Unarchiving and **deleting** stay allowed: unarchive is the one write an archived
|
||||
project must accept, and archive-then-delete is a normal sequence.
|
||||
|
||||
Nothing is removed, and unarchiving restores all of it. `server/smoketest.py`
|
||||
asserts the whole round trip.
|
||||
|
||||
## Asset freshness (why the app can't run half-updated)
|
||||
|
||||
A page must never run against a stylesheet or script from a previous deploy. Three
|
||||
|
||||
Reference in New Issue
Block a user