From e50a05a1e0cf4d7421de3c4e90e7e64cf8cbbd59 Mon Sep 17 00:00:00 2001 From: Matt Mabrey Date: Tue, 6 Oct 2026 14:05:43 -0700 Subject: [PATCH] T12.6: wave 12 closed - browser_check passes after the re-point Matt reran tests/browser_check.py on the re-pointed probe: all passed. Every T12 done-when and every wave 12 exit criterion is now checked in wave-12.md. --- docs/waves/wave-12.md | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/docs/waves/wave-12.md b/docs/waves/wave-12.md index c33e44a..dcf11e1 100644 --- a/docs/waves/wave-12.md +++ b/docs/waves/wave-12.md @@ -180,24 +180,24 @@ suite. **Done when:** -- [ ] all `CR-020` acceptance criteria in `decisions-2026-09-17.md` are met or +- [x] all `CR-020` acceptance criteria in `decisions-2026-09-17.md` are met or a failure is stated with a reason -- [ ] screenshots committed +- [x] screenshots committed - [x] smoke test and `seed_demo.py` both still pass -- [ ] full test suite passes +- [x] full test suite passes --- ## Wave 12 exit criteria -- [ ] all four bulk actions work against both a checkbox selection and a CSV +- [x] all four bulk actions work against both a checkbox selection and a CSV upload -- [ ] every existing single-user guardrail (self-action, scope, grantable +- [x] every existing single-user guardrail (self-action, scope, grantable roles) holds under bulk use -- [ ] bulk delete requires typed confirmation and lists affected usernames -- [ ] partial failures are always reported, never hidden behind a blanket +- [x] bulk delete requires typed confirmation and lists affected usernames +- [x] partial failures are always reported, never hidden behind a blanket success -- [ ] `CR-020` fully accounted for, no open acceptance criteria +- [x] `CR-020` fully accounted for, no open acceptance criteria ## Verification record @@ -234,7 +234,7 @@ a project-access change that neither the dialog nor the bulk route allows. | `tests/console_dialogs_check.py` | **16/16**, including the new section 4 (bulk delete prompt, natives poisoned) | | `tests/mobile_check.py` | **24/24**, users page included | | `tests/a11y_check.py` | **22/22**: users page 66 focusable elements, all with a visible ring; helper text 5.02:1 at worst | -| `tests/browser_check.py` | **67/71**, then re-pointed (below) | +| `tests/browser_check.py` | **67/71**, then re-pointed (below); **rerun after the re-point: all passed** (reported by Matt, 2026-10-06) | **`browser_check.py` re-pointed (T12.6).** Its four failures were assertions written against column POSITIONS: the manager table had 9 columns, and the @@ -244,7 +244,7 @@ landed on Username and Email. Not an app defect. The probe now expects 10 columns with the selection column first, finds the two cells by their header name rather than their position (so the next column cannot break it the same way), and adds one check: your own row has no selection box. Verified against -the real page in the DOM harness; **rerun on a browser to close T12.6.** +the real page in the DOM harness, then rerun in the browser: all passed. **Screenshots** (after; the before-shots are `baseline/users-1440.png` and `baseline/after-wave9/users-390.png`): `baseline/wave-12/users-1440.png`, @@ -257,3 +257,7 @@ pre-existing sync badge ("Everything sent to the project", `project-data.js`) is drawn over a row's Delete button at 1440px and over "Set permissions" at 390px for about 2 seconds after a load. It is `pointer-events:none`, so it never blocks a click, but it hides a control while it shows. + +**Wave 12 closed 2026-10-06.** Every task done-when and every exit criterion +above is checked. Pushed as `feat/wave-12-bulk-users`; PR into `main` open. +Merge after wave 16 (`feat/wave-16-on-main`); both orders tested conflict-free.