1 Commits

Author	SHA1	Message	Date
n.siegfried	4d186ea6a0	T6.3/T6.4 - CR-004 and CR-018: picked not typed, and totals that add up ... CR-004 and CR-018 are the same change seen from two ends. CR-018 is why the Acumatica cost code came out rather than being relabelled — the tracking dimension the team wants is floor and area, not an accounting code — and CR-004 is what makes that dimension exist. Committed together because a rollup keyed on free text is not a rollup, and structured location with nothing rolling up by it is a form change nobody asked for. CR-004 - three dependent dropdowns Building filters Floor filters Sector, off the project's own taxonomy from T5.4. Clearing a parent clears its children: not doing that is how a package ends up filed under a floor that is not in the building it claims. PATHS are stored, not names and not bare codes. A floor's own code is not unique across buildings; `B-ONE/L1` is. That is what lets the dashboard filter by a building and match everything beneath it with a prefix test, and it is what CR-018 groups on. The list is fetched with include_inactive=true, which is not a contradiction of CR-005's "deactivating hides it from new work packages" — they are two questions. What may be CHOSEN is active only. What may be SHOWN is everything, because a package already referencing a deactivated value still has to render its label, and blanking it on open would write the blank back on the next save. A deactivated value that IS on the package is offered, labelled "(no longer offered)"; on a fresh package it is not offered at all. Both checked. X5, checked the way aggregates_check checks its own: localStorage is poisoned with a fake building and the dropdown is required to ignore it. wp_location survives as a hidden field. A package written before this keeps what it said, and the form says so rather than dropping it. CR-018 - the rollup LOCATION_DIMENSIONS is now ("building", "floor", "sector"). T4.1's note said "only this tuple and the keys inside each group change - the response shape does not", and that held exactly. Rolled up at EVERY level, server-side, not just at the leaf. "How many on floor 2" is the question CR-018 asks and it is a level above the leaf groups; summing them in the browser would be the same per-browser arithmetic B4 removed. Actual Hours rolls up along the same dimensions - that is the field CR-017 retained, and this is why that decision mattered. Packages with no location are an explicit "(unassigned)" row, not a gap. The reason is arithmetic: a group set that silently omits them does not add up to the project total, and a rollup that does not reconcile is decoration. The probe checks every level sums to the project total, and to the estimated and actual hour totals, using distinct primes so a mis-sum cannot land on the right number by luck. A package with a building but no floor lands in the floor-level unassigned row alongside the one with no location at all - which is the honest answer, and is asserted by its hours rather than by its count. Free text captured before CR-004 groups under itself as a building rather than collapsing into unassigned, one level deep. Pretending free text is a hierarchy would file "FAB / LVL 1" under a building called "FAB / LVL 1". server/app.py dimensions, _location_levels, hours per group html/wp-creation-index.html three selects where the text box was html/wp-creation-app.js the pickers, the filters, the rollup panel html/wp-creation-styles.css .loc-picker, .loc-rollup tests/rollup_check.py new - 63 checks Done when — CR-004 [x] all three render as dropdowns populated from project configuration [x] dependent filtering works, and clearing a parent clears its children [x] values persist as codes; confirmed by reading what collectPackage stored [x] the dashboard filters by each of the three [x] a work package referencing a deactivated value still renders correctly [x] all option data comes from the server - proved by poisoning the cache Done when — CR-018 [x] the dashboard groups and totals by Building, Floor and Sector [x] totals reconcile against an unfiltered count, at every level [x] Actual Hours rolls up along the same dimensions [x] grouping is computed server-side - proved by putting nine fake packages in localStorage and requiring the panel to show none of them [x] work packages with no location appear in an explicit unassigned group No migration: location lives in the work package's JSON data blob like every other per-package field. No colour literal added. Verified one at a time rollup_check 63/63 new generalinfo_check 49/49 browser_check 71/71 pipeline 43/43 a11y 22/22 aggregates 16/16 f_items F1-F5 FIXED, F6 REPRODUCES (T7.2) Question for the PR, per CLAUDE.md: the dashboard's location filters and the rollup both key on the path, so a package saved with free text and no codes is unreachable by any location filter and sits in its own building-level row. That is correct and it is also a migration question - whether the existing free-text locations should be mapped onto the taxonomy once the B100 list arrives, or left as history. Nothing here decides it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-17 00:24:00 -05:00