T12.6: browser results, screenshots, browser_check re-pointed

Matt's run (Edge/Chrome, one at a time): bulk_users_ui_check 19/19,
console_dialogs_check 16/16, mobile_check 24/24, a11y_check 22/22.

browser_check 67/71: its four failures asserted column POSITIONS
(9 columns; r.cells[3]/[4] for Permissions/Project role). CR-020's
selection column comes first, so those read Username and Email. The
probe now expects 10 columns with the selection column first, finds
the cells by header name, and checks your own row has no selection
box. Verified on the real page in the DOM harness; rerun to close.

After-screenshots committed in docs/reference/baseline/wave-12/.
BL-061 logged: the pre-existing sync badge covers a control for ~2 s
after load (pointer-events:none, so never blocks a click); belongs
with wave 14's badge work.
This commit is contained in:
2026-10-06 11:18:39 -07:00
parent d04a0ff414
commit 912cf75027
7 changed files with 61 additions and 19 deletions

Binary file not shown.

After

Width:  |  Height:  |  Size: 128 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 112 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 97 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 78 KiB

View File

@@ -680,3 +680,19 @@ deliberately deferred.
- **Suggested wave or follow-up:** needs Nick: should a super user be able to
add or remove a shared account on their own projects? Then fix the text or
the rule, not both.
### BL-061 — The sync badge covers controls while it shows
- **Found during:** T12.6 (the wave 12 screenshots)
- **Where:** `html/project-data.js` `renderSyncBadge` (fixed bottom-right, `z-index:9998`)
- **What:** for about 2 seconds after each sync the "Everything sent to the
project" badge sits over whatever is in the bottom-right corner: a Delete
button on the User Directory at 1440px, the bulk bar's "Set permissions" at
390px. It is `pointer-events:none`, so clicks pass through, but the control is
hidden while it shows, and on the console pages there is no outbox work to
report at all.
- **Why not now:** `project-data.js` is shared by every page and owned by the
outbox work in wave 14 (T14.1 to T14.3 change this badge's states anyway).
- **Suggested wave or follow-up:** wave 14, alongside T14.1's badge changes:
do not show the badge on pages with nothing to sync, and keep it clear of
page controls.

View File

@@ -225,19 +225,35 @@ one account has it.
**Found and logged, not fixed:** BL-060, a super user's refusal reason promises
a project-access change that neither the dialog nor the bulk route allows.
**Still open: needs a machine with Edge (no browser in the build sandbox).**
Run one at a time:
**Browser probes, run 2026-10-06 on Matt's machine (Windows, Chrome 153 / Edge 154,
`.venv`), one at a time:**
```powershell
.\.venv\Scripts\python.exe tests\bulk_users_ui_check.py # writes docs\reference\baseline\wave-12\*.png
.\.venv\Scripts\python.exe tests\console_dialogs_check.py
.\.venv\Scripts\python.exe tests\mobile_check.py
.\.venv\Scripts\python.exe tests\a11y_check.py
.\.venv\Scripts\python.exe tests\browser_check.py
.\.venv\Scripts\python.exe tests\token_check.py --out after.json
```
| Probe | Result |
|---|---|
| `tests/bulk_users_ui_check.py` (new) | **19/19**: selection, Space on a row box, role change, super-user CSV (another job / not found / herself / duplicate, each by line), add-to-project with a role, typed DELETE, 390px bar fit, no JS errors |
| `tests/console_dialogs_check.py` | **16/16**, including the new section 4 (bulk delete prompt, natives poisoned) |
| `tests/mobile_check.py` | **24/24**, users page included |
| `tests/a11y_check.py` | **22/22**: users page 66 focusable elements, all with a visible ring; helper text 5.02:1 at worst |
| `tests/browser_check.py` | **67/71**, then re-pointed (below) |
Then commit the four screenshots in `docs/reference/baseline/wave-12/`
(after-shots; the before-shots are `baseline/users-1440.png` and
`baseline/after-wave9/users-390.png`). Until those pass, T12.6 and the wave
exit criteria below stay open.
**`browser_check.py` re-pointed (T12.6).** Its four failures were assertions
written against column POSITIONS: the manager table had 9 columns, and the
own-row checks read `r.cells[3]` (Permissions) and `r.cells[4]` (Project role).
CR-020's selection column is first, so the table has 10 and those indexes
landed on Username and Email. Not an app defect. The probe now expects 10
columns with the selection column first, finds the two cells by their header
name rather than their position (so the next column cannot break it the same
way), and adds one check: your own row has no selection box. Verified against
the real page in the DOM harness; **rerun on a browser to close T12.6.**
**Screenshots** (after; the before-shots are `baseline/users-1440.png` and
`baseline/after-wave9/users-390.png`): `baseline/wave-12/users-1440.png`,
`users-1440-selected.png`, `users-390.png`, `users-390-selected.png`. Reviewed:
the bar, its four groups and the selected-row marking render as designed at
both widths; nothing scrolls sideways at 390px.
**Seen in the screenshots, not caused by wave 12, logged as BL-061:** the
pre-existing sync badge ("Everything sent to the project", `project-data.js`)
is drawn over a row's Delete button at 1440px and over "Set permissions" at
390px for about 2 seconds after a load. It is `pointer-events:none`, so it never
blocks a click, but it hides a control while it shows.

View File

@@ -207,9 +207,12 @@ def run(page, base, tok):
chk("auth resolved to the admin account", page.eval("(window.WP_USER||{}).role") == "admin")
chk("the directory is visible",
page.eval("getComputedStyle(document.getElementById('users-main')).display") != "none")
chk("manager table renders 9 columns",
page.eval("document.querySelectorAll('#users-table thead th').length") == 9,
# 10 since CR-020 (T12.2): the 9 data columns plus the row-selection column.
chk("manager table renders 10 columns (9 + row selection)",
page.eval("document.querySelectorAll('#users-table thead th').length") == 10,
page.eval("document.querySelectorAll('#users-table thead th').length"))
chk("...the first is the selection column",
page.eval("!!document.querySelector('#users-table thead th.selcell #sel-all')"))
chk("an admin sees every account in the fixture (7)",
page.eval("document.querySelectorAll('#users-table tbody tr').length") == 7,
page.eval("document.querySelectorAll('#users-table tbody tr').length"))
@@ -237,15 +240,22 @@ def run(page, base, tok):
# Your own row: permissions locked so you cannot demote yourself, job function
# still editable. Asserted on the two cells, not "no select in the row".
# The cells are found by their HEADER, not by position: CR-020's selection
# column moved every column one to the right and these asserted r.cells[3]
# and [4], which then read the username and the email (T12.6).
ROW = ("const r=[...document.querySelectorAll('#users-table tbody tr')]"
".find(r=>r.querySelector('.me-tag'));")
".find(r=>r.querySelector('.me-tag'));"
"const col=n=>[...document.querySelectorAll('#users-table thead th')]"
".findIndex(h=>h.textContent.trim().toLowerCase()===n);")
def own(q):
return "(()=>{" + ROW + "if(!r)return false;const c=r.cells[3];return " + q + "})()"
return "(()=>{" + ROW + "if(!r)return false;const c=r.cells[col('permissions')];return " + q + "})()"
chk("your own permissions cell is locked, not a dropdown",
page.eval(own("!c.querySelector('select') && !!c.querySelector('.tag')")))
chk("...and wears the Administrator pill", page.eval(own("!!c.querySelector('.tag.admin')")))
chk("...while your job function stays editable",
page.eval("(()=>{" + ROW + "return !!r && !!r.cells[4].querySelector('select')})()"))
page.eval("(()=>{" + ROW + "return !!r && !!r.cells[col('project role')].querySelector('select')})()"))
chk("...and your own row cannot be ticked for a bulk action",
page.eval("(()=>{" + ROW + "return !!r && !r.querySelector('input.selbox')})()"))
page.eval("[...document.querySelectorAll('#users-table tbody button')]"
".find(b=>/project/i.test(b.textContent)).click()")